Skip to content

build: Tidy up goreleaser config #745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

jimmidyson
Copy link
Member

@jimmidyson jimmidyson commented Jun 24, 2024

This commit tidies up the goreleaser config that contained some
configuration that is no longer required, e.g. deleting the v
prefix handling code; templating the arch specific Docker image
builds (now handled by loading the arch specific image
into KinD and e2e environment); and removing the caren buildx
build container (changing the helm registry Dockerfile to be a
multistage build to only run the host compatible architecture of
mindthegap binary).

This commit tidies up the goreleaser config that contained some
configuration that is no longer required, e.g. deleting the `v`

prefix handling code; templating the arch specific Docker
image builds (now handled by loading the arch specific
image into KinD and e2e environment); and removing the
caren buildx build container (changing the helm registry
Dockerfile to be a multistage build to only run the
compatible architecture of mindthegap).
@jimmidyson jimmidyson marked this pull request as ready for review June 24, 2024 11:22
@jimmidyson jimmidyson requested review from faiq and dlipovetsky June 24, 2024 11:22
@jimmidyson jimmidyson enabled auto-merge (squash) June 24, 2024 11:40
Copy link
Contributor

@faiq faiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ran the changes and looks good.

@jimmidyson jimmidyson merged commit a64587b into main Jun 24, 2024
25 checks passed
@jimmidyson jimmidyson deleted the jimmi/remove-gotemplating-docker-image branch June 24, 2024 15:29
jimmidyson added a commit that referenced this pull request Jun 27, 2024
🤖 I have created a release *beep* *boop*
---


## 0.11.0 (2024-06-27)

<!-- Release notes generated using configuration in .github/release.yaml
at main -->

## What's Changed
### Exciting New Features 🎉
* feat: Configure namespace sync in helm chart by @dlipovetsky in
#726
* feat: Support CRS for local-path provisioner and add CSI e2e by
@jimmidyson in
#737
* feat: Support HelmAddon strategy for AWS EBS by @jimmidyson in
#732
* feat: Deploy snapshot-controller as separate addon by @jimmidyson in
#734
* feat: Update AWS CCM versions and add HelmAddon strategy by
@jimmidyson in
#748
### Fixes 🔧
* fix: Namespace Sync controller should list no resources when source
namespace is empty string by @dlipovetsky in
#725
* fix: Temporarily hard-code supported PC version for Nutanix CSI by
@jimmidyson in
#751
* fix: skip kubeadm CA file when Secret doesn't have a CA by @dkoshkin
in
#752
* fix: Correctly report failed deploy of ServiceLoadBalancer by
@dlipovetsky in
#759
### Other Changes
* build: Tidy up goreleaser config by @jimmidyson in
#745
* ci: Fix up image loading for lint-test-helm by @jimmidyson in
#746
* refactor: Tidy up Nutanix CSI with consistent apply strategy by
@jimmidyson in
#733
* test(e2e): Set empty env vars for Nutanix e2e vars by @jimmidyson in
#749
* refactor: Use recommended "default" function syntax in helm templates
by @dlipovetsky in
#750
* refactor: Reusable HelmAddon strategy by @jimmidyson in
#735
* test(e2e): Various e2e tests fixes by @jimmidyson in
#754
* test(e2e): Correct default helm release names for AWS CCM and EBS CSI
by @jimmidyson in
#756


**Full Changelog**:
v0.10.0...v0.11.0

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants